feat(MultiFileUpload): added event param to onFileDrop #8995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8995.surge.sh A11y report: https://patternfly-react-pr-8995-a11y.surge.sh |
wise-king-sullyman
approved these changes
Apr 26, 2023
tlabaj
reviewed
May 1, 2023
|
|
||
| // callback that will be called by the react dropzone with the newly dropped file objects | ||
| const handleFileDrop = (droppedFiles: File[]) => { | ||
| const handleFileDrop = (_event: DropEvent, droppedFiles: File[]) => { |
Contributor
There was a problem hiding this comment.
Not a blocker for m since this is a limitation of the documentation framework. DropEvent is not documented so the consumer doe not know what that is. I also notice DropzonOptions is not documented either.
Maybe we can add descriptions of both here until the doc framework is updated.
thatblindgeye
force-pushed
the
iss8883_multiFile_addEvent
branch
from
4a096dd to
760628f
Compare
tlabaj
approved these changes
May 2, 2023
|
|
||
| ## Types | ||
|
|
||
| Multiple file upload uses both the `DropEvent` and `DropzoneOptions` types from react-dropzone. The `DropEvent` type is a union comprised of the following types: |
Contributor
There was a problem hiding this comment.
This looks good! Thanks for adding that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8883
Additional issues: