Skip to content

Conversation

@kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Apr 27, 2023

What: Closes #8985

  • Fixes Tab/Esc focusing the toggle
  • Fixes selection focusing the toggle by passing through the toggle ref to allow a user to control the behavior. While there are less use cases of a dropdown needing to remain open after selection (unlike select which has multiple selection or typeahead), the user still controls whether the menu should stay open and if they decided to keep the menu open an internal toggle focus would be unexpected.
  • Adds a similar popper props structure that select got in the related feat(Select): add examples, add popper interface, fix focus #8992 PR

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 27, 2023

@nicolethoen nicolethoen requested review from mcarrano and tlabaj May 3, 2023 13:41
@tlabaj tlabaj requested a review from thatblindgeye May 3, 2023 13:52
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @kmcfaul !

@kmcfaul kmcfaul force-pushed the dropdown-toggle-focus branch from 9aad905 to 82df948 Compare May 3, 2023 18:01
@kmcfaul kmcfaul force-pushed the dropdown-toggle-focus branch from 4efe87e to b909cbf Compare May 8, 2023 14:55
@thatblindgeye thatblindgeye merged commit ac2d3ac into patternfly:v5 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Select/Dropdown - menutoggle doesn't receive focus on menu close

5 participants