Skip to content

Conversation

@dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented May 2, 2023

Updates Victory packages from 36.6.8 to 36.6.10

#9020

@dlabrecq dlabrecq changed the title feat(charts): Victory package update Victory package update May 2, 2023
@dlabrecq dlabrecq added the PF5 label May 2, 2023
@patternfly-build
Copy link
Contributor

patternfly-build commented May 2, 2023

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we consider adding these dependencies to renovate?

@dlabrecq
Copy link
Member Author

dlabrecq commented May 2, 2023

@tlabaj I'm not opposed to adding packages, but perhaps via a separate PR? I use dependabot, but not very familiar with renovate.

I looked at the existing renovate.json, but not sure what's the intention of excludePackagePatterns, enabled: false, etc. Are you familiar with that?

For example, I see patternfly-a11y and patternfly/documentation-framework excluded, but both are included a few lines later.

@tlabaj
Copy link
Contributor

tlabaj commented May 3, 2023

@tlabaj I'm not opposed to adding packages, but perhaps via a separate PR? I use dependabot, but not very familiar with renovate.

I looked at the existing renovate.json, but not sure what's the intention of excludePackagePatterns, enabled: false, etc. Are you familiar with that?

We can definitely have a follow up. In regards to renovate. I believe that rule says that we do not want renovate to handle all dependencies, Just the ones listed in the excludes. I am just learning it myself.

@nicolethoen nicolethoen merged commit 805fb87 into patternfly:v5 May 3, 2023
@dlabrecq dlabrecq deleted the victory-pkg-update branch June 6, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants