chore(deps): (3) Update @testing-library/react #9034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9034.surge.sh A11y report: https://patternfly-react-pr-9034-a11y.surge.sh |
Contributor
|
Looks like the testing-library version bump is causing a snapshot to change for some reason, not sure if that's expected or a sign of an issue. |
Contributor
Author
@wise-king-sullyman I am investigating. I am seeing strange behaviour where CI snapshots fail but pass locally for me... |
Contributor
|
@tlabaj worth trying a rebase here and seeing if the tests resolve themselves. |
added 9 commits
May 15, 2023 13:38
tlabaj
force-pushed
the
testing_lib_react_dep
branch
from
504d57c to
792cfe5
Compare
wise-king-sullyman
approved these changes
May 15, 2023
jpuzz0
approved these changes
May 15, 2023
kmcfaul
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: towards #8003