Skip to content

fix(DashboardWrapper): updated passing of onPageResize #9053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

fix(DashboardWrapper): updated passing of onPageResize #9053

merged 1 commit into from
May 8, 2023

Conversation

@thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented May 4, 2023

What: Closes #9052

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented May 4, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9053.surge.sh

A11y report: https://patternfly-react-pr-9053-a11y.surge.sh

nicolethoen
nicolethoen reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, when i tested this bulk select demo by opening it in a codesandbox, I still see the same error?

@nicolethoen nicolethoen self-requested a review May 4, 2023 19:45
tlabaj
tlabaj approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see an unrelated minified React errors in the console. We should open an issue and investigate.

Bulk select works for me.

@nicolethoen
Copy link
Contributor

nicolethoen commented May 4, 2023

It works in the workspace, but I don't know why the codesandbox is displaying the error still...

@thatblindgeye
Copy link
Contributor Author

thatblindgeye commented May 5, 2023

@nicolethoen Yeah I'm not too sure either... I tried updating locally places where it seemed like might be causing it, making sure onPageResize was a function, but still getting that error

@nicolethoen nicolethoen mentioned this pull request May 5, 2023
Merged
@nicolethoen nicolethoen mentioned this pull request Sep 13, 2023
Closed
@nicolethoen
Copy link
Contributor

nicolethoen commented May 8, 2023

I opened a follow up issue for the codesandbox issue, just to get some of the other work unblocked
patternfly/patternfly-org#3750

@nicolethoen nicolethoen merged commit e80f730 into patternfly:v5 May 8, 2023
@patternfly-build
Copy link
Contributor

patternfly-build commented May 8, 2023

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.94
  • @patternfly/react-core@5.0.0-alpha.93
  • @patternfly/react-docs@6.0.0-alpha.101
  • demo-app-ts@5.0.0-alpha.77
  • @patternfly/react-integration@5.0.0-alpha.39
  • @patternfly/react-table@5.0.0-alpha.95

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gitdallas gitdallas gitdallas approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@dominik-petrik dominik-petrik dominik-petrik approved these changes

@nicolethoen nicolethoen Awaiting requested review from nicolethoen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - DashboardWrapper - demos throwing error

7 participants

@thatblindgeye @patternfly-build @nicolethoen @gitdallas @tlabaj @kmcfaul @dominik-petrik