-
Notifications
You must be signed in to change notification settings - Fork 375
chore(table demos): update filterable demo from deprecated to new table #9055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-9055.surge.sh A11y report: https://patternfly-react-pr-9055-a11y.surge.sh |
nicolethoen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few things we could clean up while we are tinkering with this demo:
Looks like you can remove the following unused dependencies:
Dropdown,
DropdownItem,
DropdownPosition,
DropdownToggle,
minWidth is being passed twice to the Select on line 1376
filters is not ever used - defined on line 1399
jenny-s51
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nicolethoen ! updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think MenuToggle and MenuToggleElement need to be imported by your demo.
(BTW, i catch these by trying to open full page demos in a codesandbox when i review them. There are errors right now preventing them from working in a codesandbox - unrelated to your changes - but it still catches these sorts of unused vars and missing imports problems)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nicolethoen - added the missing imports. I'll be double-checking any demo PRs in codesandbox from now on 🙂
Good find on the import path - assigned myself to patternfly/patternfly-org#3525, will be looking into it
I think @evwilkin has done work on updating relative imports in codesandbox imports in the past. So once he's back, he may have good insights here |
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What: Closes #9030