fix(keyboard): Notification drawer and tree view keyboard handling bug fixes #9071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9071.surge.sh A11y report: https://patternfly-react-pr-9071-a11y.surge.sh |
nicolethoen
force-pushed
the
weird_dropdown_keyboard_handling
branch
from
1a55816 to
6af5af5
Compare
wise-king-sullyman
approved these changes
May 8, 2023
kmcfaul
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9016
cypress tests are very unreliable when it comes to keyboard handling. I was able to update the formerly skipped keyboard handling tests to check that the menus are opening via keyboard. However, further side effects (like moving browser focus into the menu when it opens via keyboar) does not seem so reliable to test with cypress. I don't know how it was working before. When I manually test the demo-app with keyboard it all works reliably, but the cypress tests themselves needed to be pared down to not be flakey.
Moving browser focus into the menu when keyboard opens the dropdown feels more like a dropdown test anyway, not a notification drawer test.