feat(misc): dark theme docs fixes #9084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9084.surge.sh A11y report: https://patternfly-react-pr-9084-a11y.surge.sh |
kmcfaul
force-pushed
the
dark-theme-cleanup
branch
from
94d6d8e to
6fc69e4
Compare
Contributor
Author
|
Backed out the Divider change which was causing a different axe issue. Instead updated the problematic divider example to resolve the role issue. |
nicolethoen
approved these changes
May 9, 2023
mcoker
approved these changes
May 9, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
lgtm! would it be easier to maintain if we imported the react token and used that to populate the var?
Contributor
gitdallas
approved these changes
May 10, 2023
tlabaj
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Follow up to patternfly/patternfly-org#3519
Removes custom css styling that was incompatible with dark theme.
Fixes axe issue with Divider having a role in an unordered list when it shouldn't have any role.
The text in the Brand images currently still don't reflect dark theme, but I couldn't get them to use a CSS variable properly unless it was an inline svg (and then the sizing was off). If we're okay with our examples having an inline svg I can go and investigate more.