chore(deps): update pf core dep #9108
Conversation
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import styles from '@patternfly/react-styles/css/components/ChipGroup/chip-group'; | |||
| import styles from '@patternfly/react-styles/css/components/Chip/chip-group'; | |||
There was a problem hiding this comment.
Had to update this because of this change: patternfly/patternfly#5559
|
Preview: https://patternfly-react-pr-9108.surge.sh A11y report: https://patternfly-react-pr-9108-a11y.surge.sh |
|
@mcoker - do the snapshot updates make sense with recent core changes? inset classes being removed? |
|
@gitdallas nope, glad you caught that. It's a bug in core, @mattnolting and I are looking at it now - patternfly/patternfly#5560 |
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
It seems like this does resolve the original issue.
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Wait it looks like an integration test is failing, is that just related to the other core bug mentioned above?
|
@gitdallas @wise-king-sullyman this should be fixed now in 5.0.0-alpha.53 |
| import { useState } from 'react'; | ||
| import styles from '@patternfly/react-styles/css/components/Label/label'; | ||
| import labelGrpStyles from '@patternfly/react-styles/css/components/LabelGroup/label-group'; | ||
| import labelGrpStyles from '@patternfly/react-styles/css/components/Label/label-group'; |
There was a problem hiding this comment.
update based on pf core change
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import styles from '@patternfly/react-styles/css/components/LabelGroup/label-group'; | |||
| import styles from '@patternfly/react-styles/css/components/Label/label-group'; | |||
There was a problem hiding this comment.
update based on pf core change
| @@ -1,4 +1,4 @@ | |||
| import { pfIcons } from '@patternfly/patternfly/icons/pf-icons.mjs'; | |||
| import { pfIcons } from '@patternfly/patternfly/icons/pficons.mjs'; | |||
There was a problem hiding this comment.
update based on pf core change
|
@wise-king-sullyman - right. an issue was discovered with pf core while updating @mcoker - I've had to make a few other changes (pf-icons => pficons, LabelGroup => Label), i'm not sure what to do with the background image changes. what do you think? |
|
Commented out background image related stuff, will be handled with this issue #9051 |
|
@gitdallas looks like there's just a few unit test that probably just need to be |
6 participants
will close #8993
about modal (larger X is back, backgrounds are gone) https://patternfly-react-pr-9108.surge.sh/components/about-modal