fix(Modal): remove aria-hidden from siblings when unmounting the component (v5)
#9110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component adds the aria-hidden attribute to its siblings when open and removes it when closed. However, if the component is mounted as open but then directly unmounted, its siblings will remain hidden from the accessibility API forever. Thus, the logic for removing these attributes is now also triggered when the component is unmounted.
Contributor
|
Preview: https://patternfly-react-pr-9110.surge.sh A11y report: https://patternfly-react-pr-9110-a11y.surge.sh |
nicolethoen
approved these changes
May 17, 2023
kmcfaul
approved these changes
May 17, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
…mponent (v5) (patternfly#9110) * fix(Modal): remove aria-hidden when unmount The component adds the aria-hidden attribute to its siblings when open and removes it when closed. However, if the component is mounted as open but then directly unmounted, its siblings will remain hidden from the accessibility API forever. Thus, the logic for removing these attributes is now also triggered when the component is unmounted. * fix(Modal): remove trailing spaces in test file
1 task
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Oct 19, 2023
It's no longer needed in PatternFly React >= 5.1.1 which merged the patch sent. Read more: * patternfly/patternfly-react#9110 * patternfly/patternfly-react#9096 * https://github.com/patternfly/patternfly-react/releases/tag/v5.1.1
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Oct 19, 2023
It's no longer needed in PatternFly React >= 5.1.1 which merged the patch sent. Read more: * patternfly/patternfly-react#9110 * patternfly/patternfly-react#9096 * https://github.com/patternfly/patternfly-react/releases/tag/v5.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Same than #9096, but for
v5branch.Additional issues:
Might close #8925.