-
Notifications
You must be signed in to change notification settings - Fork 375
feat(Flex): add gap support #9122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure why a Datepicker snapshot is failing here, should I update it? Edit: rebase should fix it |
|
Preview: https://patternfly-react-pr-9122.surge.sh A11y report: https://patternfly-react-pr-9122-a11y.surge.sh |
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mcarrano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tlabaj this looks good as far as I can tell. Regarding your comment about documentation, not sure what the core docs say, but agree that having some explanatory text for these examples would be helpful. If that can't be added quickly here, I'm OK to open a follow-up issue.
@mcarrano here is a link to the core content I was referring to https://pf5.patternfly.org/layouts/flex#spacing. |
|
I agree then that we should duplicate that documentation on the React page. |
mcoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's beautiful! I created this core PR to enable the gap spacers without a size suffix (but can still be used with breakpoint suffix), not sure if we want to update this PR with that change or handle that as a follow-up after the core PR merges - patternfly/patternfly#5578
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I am going to open up a follow up issue for content. I think the docs could be better organized and align more with Core docs.
We can open follow up. |
What: Closes #8397
Adds
gap,rowGap, andcolumnGaptoFlexwith breakpoints.Adds examples & updates tests.
@mcoker The issue mentions a plain
pf-m-gapclass (without the size or breakpoints) that I don't see on the modifiers list, so I left it out for now. Did I miss something?