Skip to content

Conversation

@jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented May 15, 2023

What: Closes #9003

@jenny-s51 jenny-s51 marked this pull request as draft May 15, 2023 20:56
@patternfly-build
Copy link
Contributor

patternfly-build commented May 15, 2023

@jenny-s51 jenny-s51 marked this pull request as ready for review May 16, 2023 14:39
Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: relative imports of image files are causing these demos to break in CodeSandbox.

Opened patternfly/patternfly-org#3534 to be addressed with patternfly/patternfly-org#3525

@jenny-s51 jenny-s51 requested review from nicolethoen and tlabaj May 16, 2023 14:58
@tlabaj tlabaj requested a review from mcarrano May 17, 2023 14:13
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @jenny-s51 .

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit b74e044 into patternfly:v5 May 17, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.107
  • @patternfly/react-core@5.0.0-alpha.106
  • @patternfly/react-docs@6.0.0-alpha.114
  • demo-app-ts@5.0.0-alpha.90
  • @patternfly/react-table@5.0.0-alpha.108

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Card view demo - the mock fetch is not working

6 participants