Skip to content

Revert "chore(deps): (3) Update @testing-library/react" #9126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023
Merged

Revert "chore(deps): (3) Update @testing-library/react" #9126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"@patternfly/patternfly-a11y",
"@patternfly/documentation-framework",
"@rollup/*",
"@testing-library/*",
"@testing-library/jest-dom",
"@testing-library/user-event",
"@types/jest",
"@types/react",
"@types/react-dom",
Expand Down Expand Up @@ -46,7 +47,9 @@
"@patternfly/patternfly-a11y",
"@patternfly/documentation-framework",
"@rollup/*",
"@testing-library/*",
"@testing-library/jest-dom",
"@testing-library/react-hooks",
"@testing-library/user-event",
"@types/jest",
"@types/react",
"@types/react-dom",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@babel/preset-typescript": "^7.21.5",
"@octokit/rest": "^19.0.7",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^14.0.0",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "14.4.3",
"@types/jest": "29.5.1",
"@types/react": "^18",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DatePicker/__tests__/DatePicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ test('Error state can be cleared from outside', async () => {
test('With popover opened', async () => {
const user = userEvent.setup();

const { asFragment } = render(<DatePicker value="2020-03-18" />);
const { asFragment } = render(<DatePicker />);
Copy link
Contributor

@gitdallas gitdallas May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing the value here? is that not working?

Copy link
Contributor Author

@tlabaj tlabaj May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an attempt to fix the test case that was failing in CI but passing locally for me.


await user.click(screen.getByRole('button', { name: 'Toggle date picker' }));
await screen.findByRole('button', { name: 'Previous month' });
Expand Down
Loading