feat(Input group): Simplified API #9176
Conversation
|
Preview: https://patternfly-react-pr-9176.surge.sh A11y report: https://patternfly-react-pr-9176-a11y.surge.sh |
| {...props} | ||
| > | ||
| {children} | ||
| {isBox ? <InputGroupText> {children} </InputGroupText> : children} |
There was a problem hiding this comment.
@mcoker I made the changes that we talked about. I still think we could improve this. I just don't think it is intuitive to me that applying isBox implies that we will be adding text as the input group item. I wonder if we should have a isText prop. If the consumer passes that in and they did not set "isBox" we can set it for them and render the <InputGroupText> internally as well.
| return ( | ||
| <InputGroup> | ||
| <InputGroupItem isFill>{textInput}</InputGroupItem> | ||
| <InputGroupItem isBox> |
There was a problem hiding this comment.
We should pass in the isDisabled prop from Slider into InputGroupItem here (only line 336). The disabled styling isn't applying correctly to the text when a Slider is disabled:
What it should look like:
| className, | ||
| component = 'span', |
There was a problem hiding this comment.
Should we add props to InputGroupItem to pass down to InputGroupText? With the API update the className and component won't be able to be modified.
There was a problem hiding this comment.
cc @mcoker do you think that is necessary? What is the use case where we would not want to use span?
| section: components | ||
| cssPrefix: null | ||
| propComponents: ['InputGroup', 'InputGroupItem', 'InputGroupText'] | ||
| propComponents: ['InputGroup', 'InputGroupItem', InputGroupText] |
There was a problem hiding this comment.
What exactly does this do? I'm seeing in a few places
There was a problem hiding this comment.
it adds the prop docs at bottom of page.
There was a problem hiding this comment.
i meant the removal of quotes
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
* feat(Input group): Simplified API * updates from pr review * add isDisabled prop to InputGroupText * update snapshots * update from review --------- Co-authored-by: Titani <tlabaj@redaht.com>
5 participants
What: Closes #9149