fix(BackgroundImage): Added src URL back, improved unit tests, updated screenshot #9199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9199.surge.sh A11y report: https://patternfly-react-pr-9199-a11y.surge.sh |
jpuzz0
force-pushed
the
fix/background-image
branch
from
5f734ca to
2bcc8ed
Compare
gitdallas
approved these changes
May 30, 2023
gitdallas
reviewed
May 30, 2023
| /* eslint-enable camelcase */ | ||
| style={ | ||
| { | ||
| '--pf-v5-c-background-image--BackgroundImage': `url(${src})` |
Contributor
There was a problem hiding this comment.
it would be nice if we had a token/css prop for this - preventing future "replace hard coded values" work
@tlabaj - would it be worth combining with base css prop like --${styles.backgroundImage}--BackgroundImage?
Contributor
There was a problem hiding this comment.
Agree - this PR should add a token you can set patternfly/patternfly#5633
Contributor
There was a problem hiding this comment.
@gitdallas @mcoker I think we can take this PR in as is and ope na follow up issue to the core PR.
jpuzz0
force-pushed
the
fix/background-image
branch
from
2bcc8ed to
2b23e5a
Compare
mcoker
approved these changes
May 31, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9180