feat(Pagination): add offset example #9232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9232.surge.sh A11y report: https://patternfly-react-pr-9232-a11y.surge.sh |
MariaAga
force-pushed
the
pagination-offset-example
branch
from
f33caba to
1f71338
Compare
gitdallas
requested changes
Jun 5, 2023
Contributor
gitdallas
left a comment
gitdallas
left a comment
There was a problem hiding this comment.
lgtm other than the typo below
packages/react-core/src/components/Pagination/examples/Pagination.md
Outdated
Show resolved
Hide resolved
MariaAga
force-pushed
the
pagination-offset-example
branch
from
1f71338 to
54e0229
Compare
Contributor
Author
|
The change in |
gitdallas
approved these changes
Jun 9, 2023
thatblindgeye
approved these changes
Jun 12, 2023
mcarrano
reviewed
Jun 12, 2023
Member
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
I will defer to others. I'm not really sure what this example is intended to illustrate, but seems to function as expected.
tlabaj
approved these changes
Aug 7, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9231
when having a per_page=20, and offset is 20 (skip the first 20 items ,show item numbers 21,22,23...), page should be calculated to 2, but before this change it was calculated as 1