Skip to content

Conversation

@nicolethoen
Copy link
Contributor

No description provided.

@nicolethoen nicolethoen requested a review from dgutride June 7, 2023 18:14
@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 7, 2023

steps:
- uses: actions/checkout@v3
with:
token: ${{ secrets.GH_TOKEN_REDALLEN }} # needs to be an admin token to get around branch protection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This GH token isn't tied to their personal GH account right? We might want to change it if so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else lgtm just a lint error that maybe a rebase will clean up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This GH token isn't tied to their personal GH account right? We might want to change it if so.

It's the github token that core and react have been using for years to allow CI to update the versions of dependencies and have the permissions it needs to push the changes to all the package.json files after publishing to npm. In the long term, yeah we will want to move away from them.

@nicolethoen
Copy link
Contributor Author

I tested the logic in the release playground.
This git blame shows that the next prerelease was set up after the last promotion but that the patternfly/patternfly dep was not bumped: https://github.com/patternfly-labs/pf-react-release-playground/blame/main/packages/header/package.json#L11
So it worked in the test environment

@kmcfaul kmcfaul merged commit 30a48ef into patternfly:main Jun 12, 2023
nicolethoen added a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
…fly#9253)

* chore(promote): build workflow to promote quarterly releases

* alter logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants