-
Notifications
You must be signed in to change notification settings - Fork 375
chore(promote): build workflow to promote quarterly releases #9253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-9253.surge.sh A11y report: https://patternfly-react-pr-9253-a11y.surge.sh |
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| token: ${{ secrets.GH_TOKEN_REDALLEN }} # needs to be an admin token to get around branch protection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This GH token isn't tied to their personal GH account right? We might want to change it if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else lgtm just a lint error that maybe a rebase will clean up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This GH token isn't tied to their personal GH account right? We might want to change it if so.
It's the github token that core and react have been using for years to allow CI to update the versions of dependencies and have the permissions it needs to push the changes to all the package.json files after publishing to npm. In the long term, yeah we will want to move away from them.
281edf1 to
13a2932
Compare
|
I tested the logic in the release playground. |
…fly#9253) * chore(promote): build workflow to promote quarterly releases * alter logic
No description provided.