feat(Modal): use css vars to set width, add maxWidth #9300
Merged
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9300.surge.sh A11y report: https://patternfly-react-pr-9300-a11y.surge.sh |
thatblindgeye
approved these changes
Jul 5, 2023
jenny-s51
approved these changes
Jul 7, 2023
tlabaj
requested changes
Jul 13, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Can we write unit test to verify these are being applied correctly?
tlabaj
approved these changes
Jul 19, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* feat(Modal): use css vars to set width, add maxWidth * account for number input * updated for css width * fix space in expected value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8351
Adds
maxWidthproperty.Updates
widthandmaxWidthto be set via css variables instead of directly as a style property.