Skip to content

feat(SimpleList): add ul/li classes #9302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023
Merged

feat(SimpleList): add ul/li classes #9302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e66a5
feat(SimpleList): add ul/li classes
kmcfaul Jun 22, 2023
ef69056
add class to group, update snaps
kmcfaul Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/SimpleList/SimpleList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export class SimpleList extends React.Component<SimpleListProps, SimpleListState
<div className={css(styles.simpleList, className)} {...props}>
{isGrouped && children}
{!isGrouped && (
<ul role="list" aria-label={ariaLabel}>
<ul className={css('pf-v5-c-simple-list__list')} role="list" aria-label={ariaLabel}>
{children}
</ul>
)}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/SimpleList/SimpleListGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const SimpleListGroup: React.FunctionComponent<SimpleListGroupProps> = ({
<h2 id={id} className={css(styles.simpleListTitle, titleClassName)} aria-hidden="true">
{title}
</h2>
<ul className={css(className)} role="list" aria-labelledby={id}>
<ul className={css('pf-v5-c-simple-list__list', className)} role="list" aria-labelledby={id}>
{children}
</ul>
</section>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/SimpleList/SimpleListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class SimpleListItem extends React.Component<SimpleListItemProps> {
};

return (
<li className={css(className)} {...props}>
<li className={css('pf-v5-c-simple-list__item', className)} {...props}>
<Component
className={css(
styles.simpleListItemLink,
Expand Down
2 changes: 1 addition & 1 deletion ...src/components/SimpleList/__tests__/Generated/__snapshots__/SimpleListGroup.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`SimpleListGroup should match snapshot (auto-generated) 1`] = `
/>
<ul
aria-labelledby="''"
class="''"
class="pf-v5-c-simple-list__list ''"
role="list"
>
ReactNode
Expand Down
2 changes: 1 addition & 1 deletion .../src/components/SimpleList/__tests__/Generated/__snapshots__/SimpleListItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`SimpleListItem should match snapshot (auto-generated) 1`] = `
<DocumentFragment>
<li
class="''"
class="pf-v5-c-simple-list__item ''"
>
<button
class="pf-v5-c-simple-list__item-link ''"
Expand Down
22 changes: 12 additions & 10 deletions ...ges/react-core/src/components/SimpleList/__tests__/__snapshots__/SimpleList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ exports[`SimpleList renders aria-labelled content 1`] = `
>
<ul
aria-label="This is a simple list"
class="pf-v5-c-simple-list__list"
role="list"
>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand All @@ -20,7 +21,7 @@ exports[`SimpleList renders aria-labelled content 1`] = `
</button>
</li>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand All @@ -30,7 +31,7 @@ exports[`SimpleList renders aria-labelled content 1`] = `
</button>
</li>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand All @@ -50,10 +51,11 @@ exports[`SimpleList renders content 1`] = `
class="pf-v5-c-simple-list"
>
<ul
class="pf-v5-c-simple-list__list"
role="list"
>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand All @@ -63,7 +65,7 @@ exports[`SimpleList renders content 1`] = `
</button>
</li>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand All @@ -73,7 +75,7 @@ exports[`SimpleList renders content 1`] = `
</button>
</li>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand Down Expand Up @@ -104,11 +106,11 @@ exports[`SimpleList renders grouped content 1`] = `
</h2>
<ul
aria-labelledby=""
class=""
class="pf-v5-c-simple-list__list"
role="list"
>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand All @@ -118,7 +120,7 @@ exports[`SimpleList renders grouped content 1`] = `
</button>
</li>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand All @@ -128,7 +130,7 @@ exports[`SimpleList renders grouped content 1`] = `
</button>
</li>
<li
class=""
class="pf-v5-c-simple-list__item"
>
<button
class="pf-v5-c-simple-list__item-link"
Expand Down