Update broken links. #9310
Update broken links. #9310
Conversation
|
Preview: https://patternfly-react-pr-9310.surge.sh A11y report: https://patternfly-react-pr-9310-a11y.surge.sh |
|
The long list of components on the OUIA page may need to be updated and vetted by someone who knows what should show there. Maybe @thatblindgeye or @jessiehuff ? I removed those that didn't exist on the component page in the props tables, but can make any adjustments as needed! |
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
@edonehoo I'm still finding broken links on the deprecated Application Launcher page. See my comment.
Also, on the OUIA page. Somer of the components listed were deprecated like Context selector and Options menu. So not sure if they should still be in this list. @tlabaj @nicolethoen can you advise?
| import pfLogoSm from './pf-logo-small.svg'; | ||
|
|
||
| Note: Application launcher is built on Dropdown, for extended API go to [Dropdown](/documentation/react/components/dropdown) documentation. | ||
| Note: Application launcher is built on Dropdown, for extended API go to [Dropdown](/documentation/react/components/menus/dropdown) documentation. |
There was a problem hiding this comment.
The links in this paragraph still don't work. For some reason they are in the form "/documentation/react/components..." Shouldn't they just be "/Components/..."?
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the Application Launcher page links @edonehoo . I'll defer to @nicolethoen and @tlabaj for final approval based on what they want to do with the OUIA page.
Yes, I think we should remove the deprecated components from the list. Good call @mcarrano. |
|
I think the only comment I have about the list of component links for the OUIA page is whether we really need the extraneous links like DropdownItem and NavExpandable? Or if it'd be better to link to the respective props table instead of just the component page. |
|
@thatblindgeye I was wondering that as well. If a component is OUIA compliant are all of its subcomponents also compliant? |
| It is not recommended to use an expandable alert with a `timeout` in a toast [alert group](/components/alert-group) because the alert could timeout before users have time to interact with and view the entire alert. | ||
| It is not recommended to use an expandable alert with a `timeout` in a [toast alert group](/components/alert#toast-alert-group) because the alert could timeout before users have time to interact with and view the entire alert. | ||
| See the [toast alert considerations](/components/alert/accessibility#toast-alerts) section of the alert accessibility documentation to understand the accessibility risks associated with using toast alerts. |
There was a problem hiding this comment.
this link is not working as well
There was a problem hiding this comment.
I did some investigating - I believe the link itself is correct, it's just not autoscrolling to the linked example, even though it's updating the URL. I'm not sure why.
| The following example shows how alerts can be triggered by an asynchronous event in the application. You can customize how an alert will be announced to assistive technology by adjusting the value of the `aria-live` property. Click the "start async" alert button below and then click the buttons in the above toast examples to demonstrate how asynchronous events add alerts to a group. Click the "stop async alerts" button to halt this behavior. | ||
| See the [alert group accessibility tab](/components/alert-group/accessibility) for more information on customizing this behavior. | ||
| See the [alert accessibility tab](/components/alert/accessibility) for more information on customizing this behavior. |
There was a problem hiding this comment.
This link is correct - but the accessibility doc is not available in the react workspace. it's only available when react workspace is consumed in org and built along with the accessibility docs.
...ges/react-core/src/deprecated/components/ApplicationLauncher/examples/ApplicationLauncher.md
Outdated
Show resolved
Hide resolved
...ges/react-core/src/deprecated/components/ApplicationLauncher/examples/ApplicationLauncher.md
Outdated
Show resolved
Hide resolved
* Update broken links. * Fixes more broken links. * A few edits. * Updates application launcher links. * Remove deprecated components. * fix captialization in app launcher * fix captialization in app launcher --------- Co-authored-by: nicolethoen <nthoen@redhat.com>
6 participants
Closes #9308