Skip to content

Revert "Add transformation fallback" #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Revert "Add transformation fallback" #9365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-tokens/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
},
"homepage": "https://github.com/patternfly/patternfly-react#readme",
"scripts": {
"build:single:packages": "node ../../scripts/build-single-packages.js --config single-packages.config.json",
"generate": "yarn clean && node scripts/writeTokens.js",
"clean": "rimraf dist"
},
Expand Down
5 changes: 0 additions & 5 deletions packages/react-tokens/single-packages.config.json
View file
Open in desktop

This file was deleted.

19 changes: 2 additions & 17 deletions packages/transformer-dynamic-imports/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const transformer:ts.TransformerFactory<ts.SourceFile> = context => sourceFile =
const { factory } = context
// handles relative imports import {foo} from '@patternfly/react-icons'
// the regex has extra '$ condition
if(ts.isImportDeclaration(node) && /@patternfly\/react-(core|icons|tokens)'$/.test(node.moduleSpecifier.getText())) {
if(ts.isImportDeclaration(node) && /@patternfly\/react-(core|icons)'$/.test(node.moduleSpecifier.getText())) {
if(node.moduleSpecifier.getText().includes('react-icons')) {
const importNames: string[] = []
// get all named imports
Expand All @@ -105,7 +105,7 @@ const transformer:ts.TransformerFactory<ts.SourceFile> = context => sourceFile =
}

// handle absolute icons import paths
if(ts.isImportDeclaration(node) && /@patternfly\/react-(icons|tokens)/.test(node.moduleSpecifier.getText())) {
if(ts.isImportDeclaration(node) && /@patternfly\/react-icons/.test(node.moduleSpecifier.getText())) {
if (ts.isImportDeclaration(node) && /@patternfly\/.*\/dist\/esm/.test(node.moduleSpecifier.getText())) {
return factory.updateImportDeclaration(
node,
Expand All @@ -121,21 +121,6 @@ const transformer:ts.TransformerFactory<ts.SourceFile> = context => sourceFile =
}

}

// handle any uncaught esm imports
if (ts.isImportDeclaration(node) && /@patternfly\/.*\/dist\/esm/.test(node.moduleSpecifier.getText()) && context.getCompilerOptions().module === 1) {
return factory.updateImportDeclaration(
node,
node.decorators,
node.modifiers,
node.importClause,
factory.createStringLiteral(
node.moduleSpecifier.getFullText().replace(/"/g, '').replace(/'/g, '').replace(/dist\/esm/, 'dist/js').trim(),
true
),
undefined
)
}
return ts.visitEachChild(node, visitor, context);

}
Expand Down