Skip to content

feat(Drawer): add noBackground to colorVariant #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023
Merged

feat(Drawer): add noBackground to colorVariant #9372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a0a232
feat(Drawer): add noBackground to colorVariant
kmcfaul Jul 18, 2023
1507f1d
update missed hardcoded class
kmcfaul Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-core/src/components/Drawer/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { css } from '@patternfly/react-styles';

export enum DrawerColorVariant {
default = 'default',
light200 = 'light-200'
light200 = 'light-200',
noBackground = 'no-background'
}

export interface DrawerProps extends React.HTMLProps<HTMLDivElement> {
Expand Down
3 changes: 2 additions & 1 deletion packages/react-core/src/components/Drawer/DrawerContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export interface DrawerContentProps extends React.HTMLProps<HTMLDivElement> {
/** Content rendered in the drawer panel. */
panelContent: React.ReactNode;
/** Color variant of the background of the drawer panel */
colorVariant?: DrawerColorVariant | 'light-200' | 'default';
colorVariant?: DrawerColorVariant | 'light-200' | 'no-background' | 'default';
}

export const DrawerContent: React.FunctionComponent<DrawerContentProps> = ({
Expand All @@ -31,6 +31,7 @@ export const DrawerContent: React.FunctionComponent<DrawerContentProps> = ({
className={css(
styles.drawerContent,
colorVariant === DrawerColorVariant.light200 && styles.modifiers.light_200,
colorVariant === DrawerColorVariant.noBackground && styles.modifiers.noBackground,
className
)}
ref={drawerContentRef}
Expand Down
3 changes: 2 additions & 1 deletion packages/react-core/src/components/Drawer/DrawerPanelContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export interface DrawerPanelContentProps extends React.HTMLProps<HTMLDivElement>
'2xl'?: 'width_25' | 'width_33' | 'width_50' | 'width_66' | 'width_75' | 'width_100';
};
/** Color variant of the background of the drawer panel */
colorVariant?: DrawerColorVariant | 'light-200' | 'default';
colorVariant?: DrawerColorVariant | 'light-200' | 'no-background' | 'default';
}
let isResizing: boolean = null;
let newSize: number = 0;
Expand Down Expand Up @@ -257,6 +257,7 @@ export const DrawerPanelContent: React.FunctionComponent<DrawerPanelContentProps
hasNoBorder && styles.modifiers.noBorder,
formatBreakpointMods(widths, styles),
colorVariant === DrawerColorVariant.light200 && styles.modifiers.light_200,
colorVariant === DrawerColorVariant.noBackground && styles.modifiers.noBackground,
className
)}
ref={panel}
Expand Down
3 changes: 2 additions & 1 deletion packages/react-core/src/components/Drawer/DrawerSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export interface DrawerSectionProps extends React.HTMLProps<HTMLDivElement> {
/** Content to be rendered in the drawer section. */
children?: React.ReactNode;
/** Color variant of the background of the drawer Section */
colorVariant?: DrawerColorVariant | 'light-200' | 'default';
colorVariant?: DrawerColorVariant | 'light-200' | 'no-background' | 'default';
}

export const DrawerSection: React.FunctionComponent<DrawerSectionProps> = ({
Expand All @@ -23,6 +23,7 @@ export const DrawerSection: React.FunctionComponent<DrawerSectionProps> = ({
className={css(
styles.drawerSection,
colorVariant === DrawerColorVariant.light200 && styles.modifiers.light_200,
colorVariant === DrawerColorVariant.noBackground && styles.modifiers.noBackground,
className
)}
{...props}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/PrimaryDetail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ class PrimaryDetailCardView extends React.Component {
</PageSection>
<PageSection isFilled padding={{ default: 'noPadding' }}>
<Drawer isExpanded={isDrawerExpanded} className={'pf-m-inline-on-2xl'}>
<DrawerContent panelContent={panelContent} className={'pf-m-no-background'}>
<DrawerContent panelContent={panelContent} colorVariant="no-background">
<DrawerContentBody hasPadding>{drawerContent}</DrawerContentBody>
</DrawerContent>
</Drawer>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ export const PrimaryDetailContentPadding: React.FunctionComponent = () => {
<Divider component="div" />
<PageSection padding={{ default: 'noPadding' }}>
<Drawer isExpanded={isDrawerExpanded}>
<DrawerContent panelContent={panelContent} className={'pf-m-no-background'}>
<DrawerContent panelContent={panelContent} colorVariant="no-background">
<DrawerContentBody hasPadding>{drawerContent}</DrawerContentBody>
</DrawerContent>
</Drawer>
Expand Down