feat(Table): Added isNoInset prop for flat tree tables #9427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9427.surge.sh A11y report: https://patternfly-react-pr-9427-a11y.surge.sh |
kmcfaul
reviewed
Aug 1, 2023
| isStriped?: boolean; | ||
| /** Flag indicating this table contains expandable rows to maintain proper striping */ | ||
| isExpandable?: boolean; | ||
| /** Flag rows will not have the inset typically reserved for expanding/collapsing rows in a tree table. Intended for use on tree tables with no visible rows with children. */ |
tlabaj
requested changes
Aug 1, 2023
| /** Flag indicating this table contains expandable rows to maintain proper striping */ | ||
| isExpandable?: boolean; | ||
| /** Flag rows will not have the inset typically reserved for expanding/collapsing rows in a tree table. Intended for use on tree tables with no visible rows with children. */ | ||
| isNoInset?: boolean; |
tlabaj
approved these changes
Aug 7, 2023
thatblindgeye
approved these changes
Aug 8, 2023
mattnolting
approved these changes
Aug 8, 2023
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
LGTM 👍 Might add a follow up to showcase feature in an example.
kmcfaul
approved these changes
Aug 15, 2023
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
lgtm just needs a few lint errors resolved
nicolethoen
added a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* feat(Table): Added isNoInset prop for flat tree tables * address PR comments * add example * fix linting and a11y errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8604