chore(aboutmodal): added token instead off hard coded value #9452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-o0o
force-pushed
the
9246-abouttoken
branch
from
a22c2dd to
ded55fb
Compare
Contributor
|
Preview: https://patternfly-react-pr-9452.surge.sh A11y report: https://patternfly-react-pr-9452-a11y.surge.sh |
mcoker
approved these changes
Aug 3, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Nice!! Works perfectly. Just one little nit about the import name.
| @@ -1,5 +1,6 @@ | |||
| import * as React from 'react'; | |||
| import { css } from '@patternfly/react-styles'; | |||
| import AboutModalBoxBackgroundImage from '@patternfly/react-tokens/dist/esm/c_about_modal_box_BackgroundImage'; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| import AboutModalBoxBackgroundImage from '@patternfly/react-tokens/dist/esm/c_about_modal_box_BackgroundImage'; | |
| import backgroundImage from '@patternfly/react-tokens/dist/esm/c_about_modal_box_BackgroundImage'; |
Just looking at the format of other token imports, we can probably write this shorter and with a lowercase first letter
Pagination.tsx:import widthChars from '@patternfly/react-tokens/dist/esm/c_pagination__nav_page_select_c_form_control_width_chars';
Page.tsx:import globalBreakpointXl from '@patternfly/react-tokens/dist/esm/global_breakpoint_xl';
Tooltip.tsx:import tooltipMaxWidth from '@patternfly/react-tokens/dist/esm/c_tooltip_MaxWidth';
Alert.tsx:import maxLines from '@patternfly/react-tokens/dist/esm/c_alert__title_max_lines';
ToolbarToggleGroup.tsx:import globalBreakpointLg from '@patternfly/react-tokens/dist/esm/global_breakpoint_lg';
ToolbarUtils.tsx:import globalBreakpointMd from '@patternfly/react-tokens/dist/esm/global_breakpoint_md';
ToolbarUtils.tsx:import globalBreakpointLg from '@patternfly/react-tokens/dist/esm/global_breakpoint_lg';
ToolbarUtils.tsx:import globalBreakpointXl from '@patternfly/react-tokens/dist/esm/global_breakpoint_xl';
ToolbarUtils.tsx:import globalBreakpoint2xl from '@patternfly/react-tokens/dist/esm/global_breakpoint_2xl';
Popover.tsx:import popoverMaxWidth from '@patternfly/react-tokens/dist/esm/c_popover_MaxWidth';
Popover.tsx:import popoverMinWidth from '@patternfly/react-tokens/dist/esm/c_popover_MinWidth';
MenuItem.tsx:import topOffset from '@patternfly/react-tokens/dist/esm/c_menu_m_flyout__menu_top_offset';
MenuItem.tsx:import rightOffset from '@patternfly/react-tokens/dist/esm/c_menu_m_flyout__menu_m_left_right_offset';
MenuItem.tsx:import leftOffset from '@patternfly/react-tokens/dist/esm/c_menu_m_flyout__menu_left_offset';
NotificationDrawerGroup.tsx:import maxLines from '@patternfly/react-tokens/dist/esm/c_notification_drawer__group_toggle_title_max_lines';
NotificationDrawerListItemHeader.tsx:import maxLines from '@patternfly/react-tokens/dist/esm/c_notification_drawer__list_item_header_title_max_lines';
ModalBox.tsx:import topSpacer from '@patternfly/react-tokens/dist/esm/c_modal_box_m_align_top_spacer';
ExpandableSection.tsx:import lineClamp from '@patternfly/react-tokens/dist/esm/c_expandable_section_m_truncate__content_LineClamp';
JumpLinks.tsx:import cssToggleDisplayVar from '@patternfly/react-tokens/dist/esm/c_jump_links__toggle_Display';
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
…ly#9452) * chore(aboutmodal): added token instead off hard coded value * chore(aboutmodal): changed import name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9246