Skip to content

fix(Charts, Table): Fixed lint errors in charts and table #9507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix(Charts, Table): Fixed lint errors in charts and table #9507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-charts/src/components/ChartScatter/ChartScatter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ export const ChartScatter: React.FunctionComponent<ChartScatterProps> = ({

// bubbleProperty is only considered if the size prop is undefined, therefore set
// default size function only if bubbleProperty is not set.
if (typeof rest.size === "undefined" && typeof rest.bubbleProperty === "undefined") {
if (typeof rest.size === 'undefined' && typeof rest.bubbleProperty === 'undefined') {
rest.size = ({ active }) => (active ? ChartScatterStyles.activeSize : ChartScatterStyles.size);
}

Expand Down
8 changes: 3 additions & 5 deletions packages/react-table/src/components/Table/examples/TableTreeNoInset.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ export const TableTreeNoInset: React.FunctionComponent = () => {
onCollapse: () => {},
onToggleRowDetails: () => {},
onCheckChange: (_event, isChecking) => {
setSelectedNodeNames(prevSelected => {
const otherSelectedNodeNames = prevSelected.filter(name => name === node.name);
setSelectedNodeNames((prevSelected) => {
const otherSelectedNodeNames = prevSelected.filter((name) => name === node.name);
return !isChecking ? otherSelectedNodeNames : [...otherSelectedNodeNames, node.name];
});
},
Expand All @@ -89,9 +89,7 @@ export const TableTreeNoInset: React.FunctionComponent = () => {
};

const childRows =
node.children && node.children.length
? renderRows(node.children, level + 1, 1, rowIndex + 1, isHidden)
: [];
node.children && node.children.length ? renderRows(node.children, level + 1, 1, rowIndex + 1, isHidden) : [];

return [
<TreeRowWrapper key={node.name} row={{ props: treeRow.props }}>
Expand Down