docs(TextArea): add onFocus/onBlur props to table #9513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9513.surge.sh A11y report: https://patternfly-react-pr-9513-a11y.surge.sh |
kmcfaul
force-pushed
the
textarea-props
branch
from
083d74a to
3a12189
Compare
jenny-s51
reviewed
Aug 17, 2023
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Just needs a small update to verbiage otherwise LGTM 👍
tlabaj
reviewed
Aug 23, 2023
| /** A callback for when the text area value changes. */ | ||
| onChange?: (event: React.ChangeEvent<HTMLTextAreaElement>, value: string) => void; | ||
| /** Callback function when text area is focused */ | ||
| onFocus?: (event?: any) => void; |
Contributor
There was a problem hiding this comment.
can we be more specific about event types here?
Contributor
Author
There was a problem hiding this comment.
Should I also update the typing of TextInput and FormSelect? Those have any typing as well.
Contributor
There was a problem hiding this comment.
technically changing they type for TextInput and FormSelect would be breaking. So I would leave them.
kmcfaul
force-pushed
the
textarea-props
branch
from
c5b13df to
d8608cc
Compare
jenny-s51
approved these changes
Aug 24, 2023
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
LGTM 👍 Should we open a breaking-change issue to track adding the missing event types to TextInput and FormSelect?
tlabaj
approved these changes
Aug 25, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* docs(TextArea): add onFocus/onBlur props to table * update event typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9306
Props are supported but were not explicitly in the props table unlike other similar text components.