fix(search-input): mirror search icon in rtl, fix double border #9602
Conversation
|
Preview: https://patternfly-react-pr-9602.surge.sh A11y report: https://patternfly-react-pr-9602-a11y.surge.sh |
| onClick={onSearchHandler} | ||
| isDisabled={isDisabled} | ||
| > | ||
| <ArrowRightIcon /> |
There was a problem hiding this comment.
Should this be updated no what Eric's PR #9609 went in
There was a problem hiding this comment.
I like that, what do you think @thatblindgeye and @wise-king-sullyman? Instead of adding the class directly to an icon, use the icon component. It's not hard-coding a class, and if we change the classname or how an icon mirrors/flips, it's an update to the icon component instead of potentially having to update all components that are referencing this class directly.
There was a problem hiding this comment.
I'd be in favor of that. I have a similar situation in my DataList PR. It'd also mean using our Icon component in more places as well so could be win-win.
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
We just need the snapshots updated but otherwise looks good!
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
5 participants
fixes #9600