Skip to content

fix(code-editor): force element that wraps editor to be LTR #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix(code-editor): force element that wraps editor to be LTR #9626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38c1c57
fix(code-editor): force element that wraps editor to be LTR
mcoker Sep 14, 2023
43cbc61
chore: update snaps
mcoker Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ class CodeEditor extends React.Component<CodeEditorProps, CodeEditorState> {
);

const editor = (
<div className={css(styles.codeEditorCode)} ref={this.wrapperRef} tabIndex={0}>
<div className={css(styles.codeEditorCode)} ref={this.wrapperRef} tabIndex={0} dir="ltr">
<MonacoEditor
height={height}
width={width}
Expand Down
2 changes: 2 additions & 0 deletions ...act-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ exports[`CodeEditor matches snapshot with all props 1`] = `
/>
<div
class="pf-v5-c-code-editor__code"
dir="ltr"
tabindex="0"
>
<div
Expand Down Expand Up @@ -376,6 +377,7 @@ exports[`CodeEditor matches snapshot without props 1`] = `
>
<div
class="pf-v5-c-code-editor__code"
dir="ltr"
tabindex="0"
>
<div
Expand Down