[v4] fix(InputGroup): don't add aria-describedby automatically #9671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9671.surge.sh A11y report: https://patternfly-react-pr-9671-a11y.surge.sh |
Test was setting the `aria-describedby=''` attribute to a NumericInput inside an InputGroup, most probably to avoid the autogenerated value (see patternfly#9667). However, after cleaning up the InputGroup component, `aria-describedby=''` is not a workaround anymore for unset the attribute, breaking the snapshot associated to the test.
dgdavid
changed the title
thatblindgeye
approved these changes
Oct 12, 2023
tlabaj
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same than #9670, but for
v4branch.What: Closes #9667.