fix(drawer): fix bugs#3180
Merged
mattnolting merged 10 commits intopatternfly:masterfrom Jun 19, 2020
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-3180.surge.sh |
mattnolting
reviewed
Jun 18, 2020
Collaborator
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Looking good, left a few comments
| min-width: var(--pf-c-drawer__panel--MinWidth); | ||
| } | ||
|
|
||
| &.pf-m-inline { |
Collaborator
There was a problem hiding this comment.
I don't think you need to nest this selector
Suggested change
| &.pf-m-inline { | |
| &.pf-m-inline .pf-c-drawer__panel:not(.pf-m-no-border) { |
| transform: translateX(-100%); | ||
| } | ||
|
|
||
| &.pf-m-inline { |
| .pf-c-drawer .pf-c-drawer__panel.pf-m-no-border, | ||
| .pf-c-drawer.pf-m-panel-left .pf-c-drawer__panel.pf-m-no-border { | ||
| --pf-c-drawer__panel--BoxShadow: transparent; | ||
| --pf-c-drawer__panel--BoxShadow: 0; |
Collaborator
There was a problem hiding this comment.
Suggested change
| --pf-c-drawer__panel--BoxShadow: 0; | |
| --pf-c-drawer__panel--BoxShadow: none; |
christiemolloy
changed the title
mattnolting
reviewed
Jun 18, 2020
Collaborator
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
One last comment, then it looks good!
| } | ||
|
|
||
| &.pf-m-inline .pf-c-drawer__panel:not(.pf-m-no-border) { | ||
| padding-right: var(--pf-c-drawer--m-panel-left--m-inline__panel--PaddingRight); |
Collaborator
There was a problem hiding this comment.
I think you need to disable padding-left: 0 that's added by .pf-m-inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2977
pf-c-drawer__contentwas doing anything so i removed it::afterelement that adds the "border" to the drawer component so that it matches the z-index of the notification drawer header.