fix(global): remove where from global/component var blocks#7016
Merged
mattnolting merged 3 commits intopatternfly:v6from Aug 29, 2024
Merged
fix(global): remove where from global/component var blocks#7016mattnolting merged 3 commits intopatternfly:v6from
mattnolting merged 3 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-7016.surge.sh A11y report: https://patternfly-pr-7016-a11y.surge.sh |
mcoker
force-pushed
the
remove-where-component-vars
branch
from
f29e016 to
beb1265
Compare
fix(about-modal): moved bidirect style to component scope
mattnolting
approved these changes
Aug 29, 2024
Collaborator
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
🤩🤩🤩🤩🤩🤩🤩🤩🤩🤩 LAPTM!!!
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.228 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the result of reviewing other issues/PR's and taking the first step of removing
:where()from the selector that wraps all component/layout vars, which was identified as having a negative impact on performance. That just leaves:root, .pf-[version + component]as the selector that wraps component vars.From there, we may also try some other steps to evaluate performance gains (if any) and risks to see if there are other updates to make like this for v6:
:rootfrom the selector list:where()from global reset stylesBackstopJS Report.pdf