feat(Select,Dropdown): renamed itemId prop #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitdallas
reviewed
May 24, 2023
| { | ||
| code: `import { SelectOption } from '@patternfly/react-core'; <SelectOption someProp />`, | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
not a big deal but /next for valid tests too? not sure that someProp test has much value alongside value
Collaborator
Author
There was a problem hiding this comment.
Removed the react next logic since it may not be necessary
wise-king-sullyman
approved these changes
May 24, 2023
thatblindgeye
force-pushed
the
renameItemIdProp
branch
from
fd80397 to
d29a560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #492