-
Notifications
You must be signed in to change notification settings - Fork 375
feat(Select,Dropdown): renamed itemId prop to value #9175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Select,Dropdown): renamed itemId prop to value #9175
Conversation
|
Preview: https://patternfly-react-pr-9175.surge.sh A11y report: https://patternfly-react-pr-9175-a11y.surge.sh |
|
Codemod: patternfly/pf-codemods#493 |
|
Depending on the merge order, this PR will need to be updated with these new props after this merges - or we should update this PR to include the demos updated in that PR |
kmcfaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
* feat(Select,Dropdown): renamed itemId prop to value * Renamed prop on Dropdown components
What: Closes #9101
Additional issues: