Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

What: Closes #9101

Additional issues:

@thatblindgeye thatblindgeye requested a review from kmcfaul May 24, 2023 12:56
@thatblindgeye thatblindgeye changed the title Iss9101 select item id rename feat(Select,Dropdown): renamed itemId prop to value May 24, 2023
@patternfly-build
Copy link
Contributor

patternfly-build commented May 24, 2023

@thatblindgeye
Copy link
Contributor Author

Codemod: patternfly/pf-codemods#493

@tlabaj tlabaj self-requested a review May 24, 2023 14:37
@nicolethoen
Copy link
Contributor

Depending on the merge order, this PR will need to be updated with these new props after this merges - or we should update this PR to include the demos updated in that PR

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tlabaj tlabaj merged commit 4853518 into patternfly:v5 May 25, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.120
  • @patternfly/react-core@5.0.0-alpha.119
  • @patternfly/react-docs@6.0.0-alpha.128
  • demo-app-ts@5.0.0-alpha.103
  • @patternfly/react-integration@5.0.0-alpha.50
  • @patternfly/react-table@5.0.0-alpha.122

Thanks for your contribution! 🎉

nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
* feat(Select,Dropdown): renamed itemId prop to value

* Renamed prop on Dropdown components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select - rename itemId to value

6 participants