feat(BulkSelect): disable Select none option when no rows are selected#914
Merged
karelhala merged 2 commits intopatternfly:mainfrom Apr 29, 2026
Merged
Conversation
karelhala
approved these changes
Apr 29, 2026
|
🎉 This PR is included in version 6.4.0-prerelease.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I'd like to propose change, that disable Select none(0) option in dropdown menu of BulkSelect when nothing is selected.
Why?
We're trying to follow through on UX guidelines which were acknowledged by Patternfly team as well at: patternfly/patternfly-org#4620
Current BulkSelect API doesn't allow us to do this from the outside hence the change.
Let me know what you think.