Added call to event service after reload#151
Added call to event service after reload#151christiemolloy merged 3 commits intopatternfly:masterfrom
Conversation
Signed-off-by: Gabriela S. Soria <soria.gaby@gmail.com>
|
Hi @gsoria , thank you so much for working on this! I've been testing the new functionality here: https://www.beta.katacoda.com/patternfly/courses/charts/area-chart It works really well for every step except for the initial step. Step 3, no. 1 : When I open app.js, it should(used to) render "Welcome to PatternFly" but now it won't do that unless I hit the reload button (which was not that intuitive). Step 3, no.2: This loads without having to hit the reload button, however takes about 30sec-1min Every step after this loads the changes fast, and I don't need to hit the reload button :) @dgutride was seeing the same thing. I'm wondering if you're also seeing it? |
Signed-off-by: Gabriela S. Soria <soria.gaby@gmail.com>
|
Hi @christiemolloy @dgutride, sorry for the delay. I was debugging the issue mentioned about the initial step, and I noticed that only happens in beta. I'll keep investigating the cause. I updated the PR, with the current changes in master. I've tested the changes with this scenario: Please note that this PR contains the changes only for the scenarios that use For the scenarios that use Also, I add to this PR the loading of the file Please test this change and let me know what do you think. |
|
@gsoria tested and this looks great! Do I just need to update the |
We've added a new service that listens to events defined in the scenario and allows us to override the default behavior of the platform.
For the HTML scenarios In the
gulpfile.jswe've added a new taskcallEventServicethat is executed afterreloadtask and notifies to katacoda when it is the appropriate time to hiding the progress bar.Basically this is a POST request that follows this pattern:
curl -X POST https://environment-events.katacoda.com -d "socket=$1&message=message"The socket parameter can be retrieved from the file
/tmp/socketavailable in the environment.This functionality is available in beta for now.