FEAT: Support for storage classes in file task type#58
Merged
prasadlohakpure merged 3 commits intomainfrom Apr 6, 2026
Merged
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional storage_class field to the file task so S3 writes can set the object storage class (applies to both data objects and optional _SUCCESS marker objects).
Changes:
- Introduces
storage_classconfiguration and runtime validation for thefiletask. - Passes the configured storage class through to S3
PutObjectcalls (including success marker writes). - Updates file-task documentation and adds an example pipeline YAML demonstrating the new field.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/pipelines/context_test_with_storage_class.yaml | New example pipeline showing storage_class: STANDARD_IA on an S3 file task. |
| internal/pkg/pipeline/task/file/storage_class.go | Adds storage class enumeration mapping + validation helper. |
| internal/pkg/pipeline/task/file/s3.go | Sets PutObjectInput.StorageClass from the task config. |
| internal/pkg/pipeline/task/file/README.md | Documents storage_class, lists typical values, and adds an S3 example. |
| internal/pkg/pipeline/task/file/file.go | Adds StorageClass field, default, validation, and propagation to success-file writes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mayuresh Pawar (Mayureshpawar29)
approved these changes
Apr 6, 2026
Contributor
Mayuresh Pawar (Mayureshpawar29)
left a comment
There was a problem hiding this comment.
Awesome 🔥
Divyanshu Tiwari (divyanshu-tiwari)
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for specifying the S3 storage class when writing files with the
filetask. Users can now control the storage class for both data files and success marker files written to S3. The documentation and code have been updated to reflect this new feature, and validation ensures only supported storage class values are accepted.S3 Storage Class Support
storage_classparameter to thefiletask, allowing users to set the S3 storage class (e.g.,STANDARD,STANDARD_IA, etc.) when writing files. This applies to both data and success marker files. Validation ensures only valid AWS storage class values are accepted. (file.go,storage_class.go, [1] [2] [3] [4] [5]storage_classfield, list supported values, and provide usage examples for writing to S3 with a non-default storage class. (README.md, [1] [2]Testing
context_test_with_storage_class.yaml) demonstrating usage of thestorage_classfield with thefiletask.Types of changes
Checklist