add context node_index to xpath output records #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- helps with tracking which container element the data was extracted from - useful for maintaining order or grouping related data
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a context variable node_index to the XPath task to track the order in which container nodes are processed, providing better data extraction capabilities for maintaining order and grouping related data.
- Adds 1-based node indexing to the XPath task output
- Updates documentation to explain the new context variable functionality
- Includes test cases demonstrating usage with and without node indexing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/pkg/pipeline/task/xpath/xpath.go | Implements node_index context variable generation in the main XPath processing loop |
| internal/pkg/pipeline/task/xpath/README.md | Documents the new node_index context variable and updates examples |
| test/pipelines/xpath_with_index.yaml | Test pipeline demonstrating node_index usage with jq transformation |
| test/pipelines/xpath.yaml | Basic XPath test pipeline without node indexing |
| test/pipelines/sample.html | Sample HTML file for testing XPath extraction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| if len(data) != 0 { | ||
| index := fmt.Sprintf("%d", i+1) |
There was a problem hiding this comment.
Consider using strconv.Itoa(i+1) instead of fmt.Sprintf for integer to string conversion as it's more efficient for simple integer formatting.
prasadlohakpure
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a context key
node_indexto the output records of the Xpath task. Node index is the order in which the node matched and were processed by the xpath task.