Skip to content

spark clustername fix#100

Merged
sanketjadhavSF merged 3 commits intomainfrom
sanketj-spark-clustername-fix
Apr 6, 2026
Merged

spark clustername fix#100
sanketjadhavSF merged 3 commits intomainfrom
sanketj-spark-clustername-fix

Conversation

@sanketjadhavSF
Copy link
Copy Markdown
Contributor

This pull request introduces support for an explicit ClusterName field in the clusterContext struct within the Spark EKS command implementation. The main changes ensure that the cluster name is consistently sourced from this new field, improving clarity and flexibility when managing clusters.

Cluster context and configuration improvements:

  • Added a new ClusterName field to the clusterContext struct to explicitly store the cluster's name.
  • Updated the updateKubeConfig function to use the new ClusterName field when setting the EKS cluster name in AWS CLI arguments, replacing the previous usage of execCtx.cluster.Name.
  • Modified the createSparkClients function to use the new ClusterName field when printing success messages about client creation, ensuring consistent and accurate cluster identification.

Copilot AI review requested due to automatic review settings April 6, 2026 07:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Spark-on-EKS command implementation to support an explicit cluster_name value in the Spark EKS clusterContext, and then uses that value when generating kubeconfig and when logging successful client creation.

Changes:

  • Added ClusterName to the Spark EKS clusterContext (YAML/JSON: cluster_name).
  • Updated aws eks update-kubeconfig invocation to use clusterContext.ClusterName.
  • Updated client-creation success output to print the resolved cluster name (and removed a trailing whitespace in a comment).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sanketjadhavSF sanketjadhavSF changed the title Sanketj spark clustername fix spark clustername fix Apr 6, 2026
@sanketjadhavSF sanketjadhavSF merged commit 874bd1a into main Apr 6, 2026
7 checks passed
@sanketjadhavSF sanketjadhavSF deleted the sanketj-spark-clustername-fix branch April 6, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants