Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Spark-on-EKS command implementation to support an explicit cluster_name value in the Spark EKS clusterContext, and then uses that value when generating kubeconfig and when logging successful client creation.
Changes:
- Added
ClusterNameto the Spark EKSclusterContext(YAML/JSON:cluster_name). - Updated
aws eks update-kubeconfiginvocation to useclusterContext.ClusterName. - Updated client-creation success output to print the resolved cluster name (and removed a trailing whitespace in a comment).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yash Shrivastava (alephys26)
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for an explicit
ClusterNamefield in theclusterContextstruct within the Spark EKS command implementation. The main changes ensure that the cluster name is consistently sourced from this new field, improving clarity and flexibility when managing clusters.Cluster context and configuration improvements:
ClusterNamefield to theclusterContextstruct to explicitly store the cluster's name.updateKubeConfigfunction to use the newClusterNamefield when setting the EKS cluster name in AWS CLI arguments, replacing the previous usage ofexecCtx.cluster.Name.createSparkClientsfunction to use the newClusterNamefield when printing success messages about client creation, ensuring consistent and accurate cluster identification.