Conversation
…longer than expected names :)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request extends the length of various tag columns from 64 to 128 characters in several Heimdall database tables to accommodate longer tag names.
- Updated table definitions to extend varchar columns from 64 to 128 in job_tags, job_command_tags, job_cluster_tags, command_tags, command_cluster_tags, and cluster_tags.
- Added ALTER TABLE statements to modify existing columns.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| assets/databases/heimdall/tables/job_tags.sql | Extended job_tag column length and updated its type. |
| assets/databases/heimdall/tables/job_command_tags.sql | Extended command_tag column length and updated its type. |
| assets/databases/heimdall/tables/job_cluster_tags.sql | Extended cluster_tag column length and updated its type. |
| assets/databases/heimdall/tables/command_tags.sql | Extended command_tag column length; note inconsistency in unique constraint name. |
| assets/databases/heimdall/tables/command_cluster_tags.sql | Extended command_cluster_tag column length and updated its type. |
| assets/databases/heimdall/tables/cluster_tags.sql | Extended cluster_tag column length and updated its type. |
Comments suppressed due to low confidence (1)
assets/databases/heimdall/tables/command_tags.sql:6
- The unique constraint name appears inconsistent with the table name and the naming used in similar tables. Consider renaming it to _command_tags_command_tag for consistency.
constraint _commands_tags_command_tag unique (command_tag, system_command_id)
wlggraham
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.