Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to display an error toast on the Job Details page when a job fails.
- Adds a conditional toast in JobDetails.tsx to show error messages when job status is 'FAILED'.
- Extends JobType in Helper.tsx to include an optional error field.
- Introduces a new ToastContainer component and integrates it into the app layout in layout.tsx.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/src/modules/Jobs/JobDetails/JobDetails.tsx | Added conditional toast logic to display error messages on failure. |
| web/src/modules/Jobs/Helper.tsx | Updated JobType to optionally include an error message. |
| web/src/common/ToastContainer/ToastContainer.tsx | Introduced a new ToastContainer component in the UI. |
| web/src/app/layout.tsx | Integrated the ToastContainer within the main layout. |
Josh Diaz (JoshMDiaz)
previously approved these changes
Jun 2, 2025
Josh Diaz (JoshMDiaz)
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.