fix(collection) Fix #create_index method #35
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the create_index method in the Collections API to properly support the wait and ordering query parameters that were documented but not implemented.
Key Changes:
- Added
waitandorderingparameters to thecreate_indexmethod signature - Implemented query parameter handling to pass these values to the Qdrant API
- Added comprehensive test coverage for the new parameters including individual and combined usage
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/qdrant/collections.rb | Added wait and ordering parameters to create_index method and implemented query parameter handling |
| spec/qdrant/collections_spec.rb | Added test cases for wait=false, ordering, and combined parameters |
| lib/qdrant/version.rb | Bumped version to 0.9.9.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The readme says that we can pass and as parameter, but we can't. So here is the fix
RonanLOUARN
force-pushed
the
fix/collection_create_index
branch
from
34dfc20 to
10426b7
Compare
|
@RonanLOUARN Would you like fix the specs? Thank you for your PR! |
Sorry @andreibondarev, I did not see that the linter was raising.
Don't mention it, I'll use it as soon it's merged 😉 |
|
@andreibondarev could you please publish the release to rubygems ? 🙏🏻 😊 |
It's been published. |
2 participants
Description
The readme says that we can pass
waitandorderingas parameter, but we can't.So here is the fix.