Move FlorisModel realted utilities onto FlorisModel class#13
Merged
paulf81 merged 6 commits intoMar 18, 2024
Merged
Conversation
Owner
|
This looks really great @bayc thank you! I'm going to merge in now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR moves the
FlorisModelutilitiesget_param,set_param, andprint_dictonto theFlorisModelclass and out offloris_model_utils.py.This PR also organizes the methods on
FlorisModelby functionality to make it easier to navigate for the developer. Let me know if you don't agree with this and I can remove the commit. If the reorganization if too much to view in the files changed along with moving the utility functions, you can see more localized changes with each of the commits.Related issue, if one exists
None.
Impacted areas of the software
floris_model.pyfloris_model_utils.pytests
Additional supporting information
I also updated the tests to use the relevant methods, and moves the tests to
floris_model_integration_test.pyas well asutilities_unit_test.py. I am not 100% sure that thetest_get_and_set_paramtest is a true integration test or more of a unit test, but seemed to fit well in thefloris_model_integration_test.pyfile.Test results, if applicable
Tests are passing.