Skip to content

Move FlorisModel realted utilities onto FlorisModel class#13

Merged
paulf81 merged 6 commits into
paulf81:feature/floris_model_utils_2from
bayc:feature/floris_model_utils_2
Mar 18, 2024
Merged

Move FlorisModel realted utilities onto FlorisModel class#13
paulf81 merged 6 commits into
paulf81:feature/floris_model_utils_2from
bayc:feature/floris_model_utils_2

Conversation

@bayc
Copy link
Copy Markdown

@bayc bayc commented Mar 15, 2024

Feature or improvement description
This PR moves the FlorisModel utilities get_param, set_param, and print_dict onto the FlorisModel class and out of floris_model_utils.py.

This PR also organizes the methods on FlorisModel by functionality to make it easier to navigate for the developer. Let me know if you don't agree with this and I can remove the commit. If the reorganization if too much to view in the files changed along with moving the utility functions, you can see more localized changes with each of the commits.

Related issue, if one exists
None.

Impacted areas of the software
floris_model.py
floris_model_utils.py
tests

Additional supporting information
I also updated the tests to use the relevant methods, and moves the tests to floris_model_integration_test.py as well as utilities_unit_test.py. I am not 100% sure that the test_get_and_set_param test is a true integration test or more of a unit test, but seemed to fit well in the floris_model_integration_test.py file.

Test results, if applicable
Tests are passing.

@paulf81 paulf81 requested review from paulf81 and rafmudaf March 18, 2024 21:41
@paulf81
Copy link
Copy Markdown
Owner

paulf81 commented Mar 18, 2024

This looks really great @bayc thank you! I'm going to merge in now

@paulf81 paulf81 merged commit a37e707 into paulf81:feature/floris_model_utils_2 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants