feat: add support for SSL certificate verification in CLI and connection#47
feat: add support for SSL certificate verification in CLI and connection#47srimon12 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/qql/cli.py`:
- Around line 205-207: The temporary QdrantClient created for connectivity
validation (the instantiation of QdrantClient followed by
client.get_collections()) is never closed and can leak sockets; update the check
to either use a context manager (with QdrantClient(...) as client:
client.get_collections()) or ensure client.close() is called in a finally block
before proceeding to launch the REPL (references: QdrantClient and
client.get_collections()) so the probe client is always cleaned up.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9b21a542-7185-47e5-b581-57ca791b0f5e
📒 Files selected for processing (10)
README.mddocs/getting-started.mddocs/programmatic.mddocs/reference.mdsrc/qql/__init__.pysrc/qql/cli.pysrc/qql/config.pysrc/qql/connection.pytests/test_cli.pytests/test_connection.py
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a configurable TLS verification setting: a ChangesTLS Verification Control
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
fix #46
fix: support custom TLS verification for Qdrant connections
Add TLS verification controls for HTTPS Qdrant deployments that use
self-signed certificates or internal CAs.
Changes:
qql connect --no-verifyfor trusted internal/self-signed setupsqql connect --ca-cert <path>for custom CA bundles~/.qql/config.json--ca-certand--no-verifyusageverify: bool | strinQQLConfigwith backwards-compatible defaultsconnect,execute,dump,REPL startup,
Connection, andrun_queryCloses #46
Summary by CodeRabbit
New Features
--verify/--no-verifyand--ca-cert, persisted in config.verify(accepts True/False or CA path) for one-shot and persistent connections.Documentation
--no-verify.