Add FB2 format support #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Could you send me one book that shows up and the one that doesnt? Also if possible a metadata file generated by KoReader (koshelf@paviro.de) |
- Added BookFormat enum with Epub and Fb2 variants - BookFormat::from_path() detects format from extension (including .fb2.zip) - BookFormat::metadata_filename() returns the correct KOReader metadata filename - Replaced is_epub/is_fb2 booleans in book_scanner.rs with BookFormat - Removed metadata fallback
- FB2 parser now handles .fb2.zip files by extracting from archive - BookFormat::is_metadata_file() centralizes metadata file detection - file_watcher uses BookFormat for cleaner file type detection
Owner
|
All the books you send me work now. Also found a bug in the metadata parsing didn't support bookmarks yet as I have never used them haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
src/fb2_parser.rs) to extract metadata from FB2 files.fb2and.fb2.zipfilesCargo.tomlSupported FB2 Features
.fb2and.fb2.zipformatsTesting
Notes