Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the androidx.compose.material:material-icons-extended dependency and replaces all Material Icons usage with manually imported XML drawable resources, following the recommended approach since Material3 version 1.4.0.
- Removed the
material-icons-extendeddependency from the build configuration - Added 40+ XML drawable resources for icons that were previously imported from Material Icons
- Updated all Kotlin code to use
painterResource(R.drawable.*)instead ofIcons.* - Changed function signatures to accept
@DrawableRes Intparameters instead ofImageVector
Reviewed changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Removed materialIconsExtended version declaration and library reference |
| app/build.gradle.kts | Removed androidx.material.icons.extended dependency |
| app/src/main/res/drawable/*.xml | Added 40+ XML drawable resources for icons (solid and outlined variants) |
| app/src/main/java/de/pawcode/cardstore/ui/sheets/OptionsSheet.kt | Updated Option data class to use @DrawableRes Int instead of ImageVector |
| app/src/main/java/de/pawcode/cardstore/ui/screens/*.kt | Updated all screen components to use painterResource() with drawable resources |
| app/src/main/java/de/pawcode/cardstore/ui/components/*.kt | Updated all reusable components to accept Painter or @DrawableRes Int parameters |
| app/src/main/java/de/pawcode/cardstore/ui/dialogs/ConfirmDialog.kt | Removed unused icon parameter from dialog |
| .gitignore | Added .idea/copilot.* to ignored files |
|
🎉 This PR is included in version 1.4.2-staging.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently this is the way to go since: https://developer.android.com/jetpack/androidx/releases/compose-material3#1.4.0