feat(M-Q27): quality-gate.sh task-tag → parent-milestone fallback#123
Merged
Conversation
Closes recurring test-runner blocker pattern: dev sessions report
"готово M-L1-T2" (task ID), test-runner runs `quality-gate.sh M-L1-T2`,
step 6 fails because no `scripts/verify_M-L1-T2.sh` exists. Architect
keeps writing per-task scripts repeatedly (M-L1-T2, M-L1-T3, M-Q26)
вместо ONE per milestone.
Fix: 3-step fallback chain в quality-gate.sh step 6:
1. exact: scripts/verify_<TAG>.sh
2. parent-tag: strip `-T<N>(.<N>)*[a-z]*` suffix → try
scripts/verify_<PARENT>.sh OR family verify_<PARENT>-*.sh
3. header-grep (existing): `# <TAG>` в header any verify_*.sh
Resolutions:
M-L1-T2 → M-L1 → family verify_M-L1-expansion.sh ✓
M-L1-T15 → M-L1 → family ✓
M-L1-T2.5-impl → M-L1 → family ✓
M-Q26 → no strip → exact verify_M-Q26.sh ✓
M-L1-expansion → no strip → exact ✓
Acceptance: scripts/verify_M-Q27.sh — 8 checks
(PARENT_TAG resolution, sed regex 6 cases, live M-L1-T2 → expansion).
Local dry-run: PASS=8 FAIL=0.
Convention update в follow-up session — dev-startup.md + test-runner.md
should mention "use parent milestone tag" but существующий fallback
делает это less critical.
Effect: dev sessions могут продолжать reporting task tags; architect
больше НЕ нужно писать verify_<task>.sh per task. ONE script per
milestone (verify_M-L1-expansion.sh, verify_M-Q24.sh, etc.) covers all
tasks in that milestone via fallback.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes recurring test-runner blocker. Dev sessions report task tags (M-L1-T2, M-L1-T3, M-Q26); architect writes per-milestone acceptance scripts (verify_M-L1-expansion.sh, verify_M-Q24.sh). quality-gate.sh step 6 was failing because no exact verify_.sh existed.
Fix
3-step fallback chain в quality-gate.sh step 6:
scripts/verify_<TAG>.sh-T<N>(.<N>)*[a-z]*suffix → tryverify_<PARENT>.shOR familyverify_<PARENT>-*.sh# <TAG>в header any verify_*.shResolutions
verify_M-L1-expansion.shverify_M-L1-expansion.shverify_M-L1-expansion.shverify_M-Q26.shverify_M-L1-expansion.shAcceptance
scripts/verify_M-Q27.sh— 8 checks (PARENT_TAG resolution + 6 sed regex cases + live M-L1-T2 → expansion). Dry-run: PASS=8 FAIL=0.Effect
Dev sessions могут продолжать reporting task tags. Architect пишет ONE script per milestone (verify_M-L1-expansion.sh, verify_M-Q24.sh) — все tasks в этой milestone covered via fallback. Зомби-pattern «test-runner всегда RED'ом на missing acceptance» закрыт.
🤖 Generated with Claude Code