test(M-L10.7.3): RED — Header + Footer refactor (inline styles → design class names)#99
Open
a3ka wants to merge 2 commits into
Open
test(M-L10.7.3): RED — Header + Footer refactor (inline styles → design class names)#99a3ka wants to merge 2 commits into
a3ka wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a3ka
pushed a commit
that referenced
this pull request
May 3, 2026
…* packages Pre-existing infrastructure debt: packages/types/src/index.ts uses .js extension imports (TS NodeNext). Next.js webpack does NOT transpile workspace packages by default — fails to resolve './agent-category.js' (actual file: agent-category.ts). Broke at M-L1-taxonomy merge (commit 120988e, ~April 30). Last successful landing CI: f4cefcf (April 30). Path-filtered landing CI didn't trigger on backend PRs (#118-#125) → silent for 3 days. PR #99 (M-L10.7.3) is first PR touching landing since → CI red → exposes baseline. Affects all 8 frontend apps' production builds + likely silently breaks their Vercel deploys. Acceptance script verifies (17 checks): 1. all 8 apps' next.config.ts have transpilePackages field (8 checks) 2. transpilePackages includes @paxio/types (8 checks) 3. landing-app build succeeds (1 smoke check) Currently RED 0/17 (no transpilePackages in any config; landing-app build fails on .js resolution). Fix is frontend-dev scope — slim spec in docs/sprints/TD-FE-transpile.md.
…gn class names)
Visual fidelity round-3. Static analysis нашёл architectural drift:
Header.tsx (385 lines) + Footer.tsx (180 lines) построены на 16 inline
style={} блоках вместо design source class names. CSS rules для .hdr-*,
.foot-*, #paxio-header, #page-foot УЖЕ ported в landing's paxio-b3-page.css
(M-L10.6 byte-identical port), но компоненты их игнорируют.
Three concrete discrepancies pinned:
D-1. Header.tsx — refactor to design source structure:
- <header id="paxio-header"> (was className="paxio-header" — wrong selector)
- .hdr-inner / .hdr-brand / .hdr-mark / .hdr-wordmark / .hdr-tagline /
.hdr-links / .hdr-actions / .hdr-cta / .hdr-cta-outline /
.hdr-cta-primary / .hdr-live / .hdr-theme-btn
- Drop layout inline styles (≤4 style={{}} for SVG-internal only)
D-2. Footer.tsx — refactor to design source structure:
- <footer id="page-foot"> (no id currently)
- .foot-inner / .foot-brand / .foot-mark / .foot-tagline / .foot-cols /
.foot-h / .foot-legal
- 3-column sitemap: Product / Builders / Company
- Tagline "Financial OS for the agentic economy"
D-3. layout.tsx body data-attributes per design:
- Add data-density="regular" + data-accent="classic"
- Keep data-production="false" (R-FE-Preview disclosure preserved)
- Keep data-motion=...
This is pure refactor — все CSS rules уже в landing's CSS files. No new
CSS needed; just remove inline styles and apply class names.
Verified locally:
pnpm typecheck — clean
Targeted vitest — 19 failed | 6 passed (RED expected — frontend-dev impl pending)
Branch base: origin/dev=f4cefcf.
…ass names T-1 Header.tsx: id=paxio-header + .hdr-inner/.hdr-brand/.hdr-wordmark/.hdr-links/.hdr-actions/.hdr-cta-outline/.hdr-cta-primary/.hdr-live applied. Removed 16 layout inline styles. Preserved ≤4 SVG-internal style blocks. T-2 Footer.tsx: id=page-foot + .foot-inner/.foot-brand/.foot-mark/.foot-tagline/.foot-cols/.foot-h/.foot-legal applied. 3-column sitemap (Product/Builders/Company). Removed all layout inline styles. Removed unused 'use client' + Dialog import. T-3 layout.tsx: added data-density=regular + data-accent=classic to body. Baseline: 1382 passed | 26 skipped | 5 todo. CSS coverage: 264 className tokens resolve cleanly. Typecheck: clean.
a3ka
force-pushed
the
feature/M-L10.7.3-header-footer-classes
branch
from
348c474 to
63f55d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Pure refactor: replace 16 inline
style={}blocks in Header.tsx (385 lines) + Footer.tsx (180 lines) with design source class names. CSS rules for.hdr-*/.foot-*ALREADY ported inpaxio-b3-page.css; components just need to use them.Three discrepancies pinned
Header.tsx<header className="paxio-header">+ 16 inline styles<header id="paxio-header">+.hdr-inner/.hdr-brand/.hdr-mark/.hdr-wordmark/.hdr-tagline/.hdr-links/.hdr-actions/.hdr-cta/.hdr-cta-outline/.hdr-cta-primary/.hdr-liveFooter.tsxid="page-foot"<footer id="page-foot">+.foot-inner/.foot-brand/.foot-mark/.foot-tagline/.foot-cols/.foot-h/.foot-legal+ 3-col sitemap (Product/Builders/Company)layout.tsxbodydata-production="false"+data-motiondata-density="regular"+data-accent="classic"Test plan
frontend-dev slim spec
🤖 Generated with Claude Code