Merged
Conversation
Added wallet-level script types with a shared ScriptType enum, wired addresses to inherit it, and updated weight calculations to use script pubkey lengths and per-script input/output weights instead of the previous hardcoded taproot assumptions. Also updated coin selection input weights and the expected test weight.
Mshehu5
reviewed
Mar 5, 2026
| use bdk_coin_select::{ | ||
| metrics::LowestFee, Candidate, ChangePolicy, CoinSelector, Drain, DrainWeights, Target, | ||
| TargetFee, TargetOutputs, TR_DUST_RELAY_MIN_VALUE, TR_KEYSPEND_TXIN_WEIGHT, | ||
| TargetFee, TargetOutputs, TR_DUST_RELAY_MIN_VALUE, |
Contributor
There was a problem hiding this comment.
ACK b82312b
Niit: Seems the dust limit that's still used is taproot for all srcipt types might be important in future based on yesterdays office hours
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added wallet-level script types with a shared ScriptType enum, wired addresses to inherit it, and updated weight calculations to use script pubkey lengths and per-script input/output weights instead of the previous hardcoded
taproot assumptions. Also updated coin selection input weights and the
expected test weight.