Fix all clippy warnings across the codebase#23
Merged
Conversation
Contributor
Author
Collaborator
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Thank you for taking this chore on!! Huge.
Address warnings from `cargo clippy --workspace --all-targets --all-features` : renamed deprecated `gen_range` to `random_range`, simplified iterator/borrow patterns, derived `Default` where possible, used `div_ceil`/`is_multiple_of`, switched HashMap access to `entry` API, dropped redundant closures and `clone()` on Copy types, and annotated intentionally unused API methods with `#[allow(dead_code)]`. Add clippy check to CI workflow Add clippy linting step to CI with -D warnings flag scope `#[allow(dead_code)]` to specific items Replace file-level dead_code suppression to only where necessary
Contributor
Author
|
@arminsabouri fixed the concerns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr resolves all
cargo clippy --workspace --all-targets --all-featureswarnings so the tree builds clean under clippy.closes #20