Remove WalletView infavor of individual methods#25
Conversation
arminsabouri
force-pushed
the
rm-wallet-view
branch
2 times, most recently
from
e5d3fcb to
d0cdf9d
Compare
Mshehu5
left a comment
Mshehu5
left a comment
There was a problem hiding this comment.
cACK but currently strategies take &WalletHandleMut even though they appear to only read state. Given the existing WalletHandle/WalletHandleMut split should we move strategies to &WalletHandle in a follow-up PR so we have clear read/write boundary? Or if WalletHandle is no longer intended to be used it should probably be removed in a follow-up instead.
arminsabouri
force-pushed
the
rm-wallet-view
branch
from
d0cdf9d to
e2d0f96
Compare
Good call! This has been addressed in e2d0f96 |
3 participants
Since we use wallet view in our strategies and actions (as of #12 ) there is no strong reason for wallet view to also exist. In a sense its duplicate data.
closes #24
Most of the refactoring was done by claude sonnet